Skip to content

fix BookmarkValueType #17

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 7, 2020

Conversation

saitoukun
Copy link
Contributor

@saitoukun saitoukun commented Jul 7, 2020

Thanks for the cool package!

Fixes #18


This is how it looks in notion.

(Sorry for the Japanese words mixed in with the examples.)
スクリーンショット 2020-07-07 10 31 37

The value when notion fails to fetch the bookmark.

{
  id: '{your_id}',
  version: 3,
  type: 'bookmark',
  properties: { link: [ [Array] ] },
  created_time: 1593341091859,
  last_edited_time: 1593341040000,
  parent_id: {your_id}',
  parent_table: 'block',
  alive: true,
  copied_from: '{your_id}'
  created_by_table: 'notion_user',
  created_by_id: '{your_id}'
  last_edited_by_table: 'notion_user',
  last_edited_by_id: '{your_id}'
  shard_id:'{your_id}'
  space_id: '{your_id}'
}


If you accept this PR, you will see this.

スクリーンショット 2020-07-07 10 31 47

Copy link
Member

@tobiaslins tobiaslins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Looking good :)

@tobiaslins tobiaslins merged commit 9a7c5d1 into splitbee:master Jul 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BookmarkValueType may not include format.
2 participants